tbouron commented on a change in pull request #164: auto-set a name for the app 
in quick-launch, and
URL: https://github.com/apache/brooklyn-ui/pull/164#discussion_r366239448
 
 

 ##########
 File path: ui-modules/utils/quick-launch/quick-launch.js
 ##########
 @@ -38,7 +38,7 @@ export function quickLaunchDirective() {
         scope: {
             app: '=',
             locations: '=',
-            args: '=?',
+            args: '=?', // default: { noEditButton: false, noComposerButton: 
false, noCreateLocationLink: false, location: null }
 
 Review comment:
   Where this default comes from? It not enforce anywhere nor used.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to