tbouron commented on a change in pull request #164: auto-set a name for the app
in quick-launch, and
URL: https://github.com/apache/brooklyn-ui/pull/164#discussion_r366240445
##########
File path: ui-modules/utils/quick-launch/quick-launch.js
##########
@@ -47,11 +47,21 @@ export function quickLaunchDirective() {
function controller($scope, $http, $location, brSnackbar) {
$scope.deploying = false;
$scope.model = {
- newConfigFormOpen: false
+ newConfigFormOpen: false,
+
+ // should never be null, so the placeholder in UI for model.name
will never be used;
+ // hence autofocus is disabled
Review comment:
The name field might be filled up, but the input itself is not disabled, and
there are other fields in the form so `autofocus` should be set on one of these.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
