tbouron commented on a change in pull request #164: auto-set a name for the app
in quick-launch, and
URL: https://github.com/apache/brooklyn-ui/pull/164#discussion_r366237370
##########
File path: ui-modules/home/app/views/main/deploy/deploy.controller.js
##########
@@ -80,9 +79,17 @@ export function deployStateController($scope, $state,
$stateParams, $uibModal, b
function modalController($scope, $location, entitySpec, locations) {
$scope.app = entitySpec;
- $scope.locations = locations;
- // can optionally add: { noEditButton: true, noComposerButton: true },
or pass in URL
- $scope.args = angular.extend({}, $location.search());
+ $scope.locations = filterCatalogQuickLaunch(locations, (t) => {
+ $scope.usingCatalogQuickLaunchTags = t.length > 0;
+ });
+
+ // also supports { noEditButton: true, noComposerButton: true }
+ // see quick-launch.js for more info
+ $scope.args = angular.extend({
+ noCreateLocationLink: $scope.usingCatalogQuickLaunchTags
Review comment:
Why disabling the location creation button if there are quick launch items?
It doesn't really make sense to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
