ahgittin commented on a change in pull request #195:
URL: https://github.com/apache/brooklyn-ui/pull/195#discussion_r609538002
##########
File path:
ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js
##########
@@ -346,9 +346,10 @@ export function catalogSelectorDirective() {
if (!rowsPerPage) {
let palette =
angular.element(document.querySelector(".page-main-area"));
let toolbar =
angular.element(document.querySelector(".navbar-mode"));
+ let title = 56;
let header =
angular.element($element[0].querySelector(".catalog-palette-header"));
let footer =
angular.element($element[0].querySelector(".catalog-palette-footer"));
- rowsPerPage = Math.max(MIN_ROWS_PER_PAGE,
Math.floor((palette[0].offsetHeight - (toolbar[0].offsetHeight +
header[0].offsetHeight + footer[0].offsetHeight + 16)) /
($scope.state.viewMode.rowHeightPx || 96)));
+ rowsPerPage = Math.max(MIN_ROWS_PER_PAGE,
Math.floor((palette[0].offsetHeight - (toolbar[0].offsetHeight + title +
header[0].offsetHeight + footer[0].offsetHeight + 32)) /
($scope.state.viewMode.rowHeightPx || 96)));
Review comment:
prevents it from needing to scroll vertically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
