ahgittin commented on a change in pull request #195:
URL: https://github.com/apache/brooklyn-ui/pull/195#discussion_r609540703
##########
File path: ui-modules/catalog/app/views/catalog/catalog.template.html
##########
@@ -98,18 +98,29 @@ <h4 class="media-heading">
</div>
<div class="extra" uib-collapse="isCollapsed">
+ <!-- note entities are not filtered as search changes;
but they will take an initial search; not intuitive -->
<div ng-init="filteredEntities = (bundle.types |
bundleTypeFilter:'org.apache.brooklyn.api.entity.Entity' |
filter:state.search)" ng-show="::filteredEntities.length > 0">
<ul class="list-group list-group-types">
<li class="list-group-item
typed-group-table-header">
<ng-pluralize
count="::filteredEntities.length"
when="{'one': 'Entity', 'other':
'Entities'}">
</ng-pluralize>
</li>
- <li ng-repeat="entity in filteredEntities
track by (entity.containingBundle + entity.symbolicName + entity.version)"
+ <li ng-repeat="entity in ::filteredEntities
track by (entity.containingBundle + entity.symbolicName + entity.version)"
+ ng-if="!isCollapsed && $index <
pagination.itemsPerPage"
ng-class="{'deprecated':
entity.deprecated, 'disabled': entity.disabled}"
class="list-group-item">
- <type-item bundle="bundle"
type="entity"></type-item>
+ <type-item bundle="::bundle"
type="::entity"></type-item>
Review comment:
the `::` here doesn't achieve much, as the digest re-renders `type-item`
isolated scope anyway :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
