ahgittin commented on a change in pull request #195:
URL: https://github.com/apache/brooklyn-ui/pull/195#discussion_r609539613
##########
File path: ui-modules/catalog/app/views/bundle/type/type.template.html
##########
@@ -20,8 +20,8 @@
<header class="row">
<div class="col-md-12">
<div class="media">
- <div class="media-left">
- <img ng-src="{{type | iconGeneratorPipe:'symbolicName'}}"
class="media-object" alt="{{::type.symbolicName}}'s logo" />
+ <div class="media-left" ng-if="type.symbolicName">
Review comment:
`ng-if` is needed to prevent `::type | ...` being evaluated when `type`
is set but not populated, also elsewhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
