Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/41#discussion_r14506650
--- Diff:
core/src/main/java/brooklyn/entity/rebind/persister/BrooklynMementoPersisterToObjectStore.java
---
@@ -70,6 +115,9 @@ public PersistenceObjectStore getObjectStore() {
@Override
public void stop() {
running = false;
+ if (executor != null) {
+ executor.shutdownNow();
--- End diff --
do we need to allow the writes to complete, at least on a graceful
shutdown? feels like we'd lose data otherwise.
think either make this always graceful, or take a `boolean graceful` if
there's a use case for immediate shutdown
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
