Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/83#discussion_r15520453
--- Diff:
utils/common/src/main/java/brooklyn/util/javalang/RunnableAdapter.java ---
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package brooklyn.util.javalang;
+
+import java.util.concurrent.Callable;
+
+public class RunnableAdapter<T> implements Callable<T> {
--- End diff --
I'd be tempted to put this in `brooklyn.util.concurrent` instead. Not sure
if `RunnableAdapter` is best name, as that doesn't indicate that it will be
`Callable`.
Accessing it as a static method on some class, e.g. feeling like
`Executors.callable(job, result)` but definitely not called `Executors`, might
also be nicer.
I presume the only reason we want this is for the nicer toString?
I'd either make the fields private or protected.
Suggest marking as `@Beta` as well, for if we think of better names and/or
move it again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
