Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/113#discussion_r16473356
--- Diff: core/src/main/java/brooklyn/util/osgi/Osgis.java ---
@@ -195,7 +196,22 @@ private static void installBootBundles(Framework
framework) {
Map<String, Bundle> installedBundles =
getInstalledBundles(bundleContext);
while(resources.hasMoreElements()) {
URL url = resources.nextElement();
- installExtensionBundle(bundleContext, url, installedBundles,
getVersionedId(framework));
+ ReferenceWithError<Boolean> installResult =
installExtensionBundle(bundleContext, url, installedBundles,
getVersionedId(framework));
+ if (installResult.hasError()) {
+ if (installResult.getMaskingError()) {
--- End diff --
This name threw me - I thought it was going to return the masking error,
rather than the boolean result.
Let's go with what is here for this PR, but I think that
`ReferenceWithError` could do with improvements to make it easier to
use+understand. We should mark it as `@Beta` until we're definitely happy with
it as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
