Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/113#discussion_r16539033
--- Diff:
usage/rest-server/src/test/java/brooklyn/rest/BrooklynRestApiLauncher.java ---
@@ -238,7 +241,7 @@ private static void
installBrooklynFilters(ServletContextHandler context) {
/** starts a server, on all NICs if security is configured,
* otherwise (no security) only on loopback interface */
- private Server startServer(ManagementContext mgmt, ContextHandler
context, String summary) {
+ public static Server startServer(ManagementContext mgmt,
ContextHandler context, String summary) {
--- End diff --
Why were these made private originally? Is there a better recommended
approach? If there was a good reason, should these be marked as `@Deprecated`?
@sjcorbett I believe you made them private - any comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
