Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/113#discussion_r16474353
--- Diff:
core/src/test/java/brooklyn/entity/basic/AbstractEntityLegacyTest.java ---
@@ -147,7 +148,7 @@ public void testNewStyleSetsDefaultDisplayName() throws
Exception {
@Test
public void testNewStyleUsesCustomDisplayName() throws Exception {
--- End diff --
This test is in the wrong place. The rest of `AbstractEntityLegacyTest` is
for constructing entities directly, whereas this uses the `EntitySpec` so is
not "legacy". It should probably be in `EntitySpecTest`. But that doesn't need
addressed in this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
