Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/197#discussion_r18205597
--- Diff:
core/src/main/java/brooklyn/entity/basic/EntityReadOnlyInternal.java ---
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package brooklyn.entity.basic;
+
+import java.util.Collection;
+import java.util.Map;
+import java.util.Set;
+
+import javax.annotation.Nonnull;
+import javax.annotation.Nullable;
+
+import brooklyn.basic.BrooklynObjectInternal;
+import brooklyn.config.ConfigKey;
+import brooklyn.config.ConfigKey.HasConfigKey;
+import brooklyn.entity.Application;
+import brooklyn.entity.Effector;
+import brooklyn.entity.Entity;
+import brooklyn.entity.EntityType;
+import brooklyn.entity.Group;
+import brooklyn.entity.basic.EntityInternal.FeedSupport;
+import brooklyn.entity.rebind.RebindSupport;
+import brooklyn.entity.rebind.Rebindable;
+import brooklyn.event.AttributeSensor;
+import brooklyn.location.Location;
+import brooklyn.management.ManagementContext;
+import brooklyn.management.internal.EntityManagementSupport;
+import brooklyn.mementos.EntityMemento;
+import brooklyn.policy.Enricher;
+import brooklyn.policy.Policy;
+import brooklyn.util.config.ConfigBag;
+import brooklyn.util.guava.Maybe;
+
+import com.google.common.annotations.Beta;
+
+/**
+ * Selected methods from {@link EntityInternal} and parents which are
permitted
+ * in read-only mode.
+ */
+@Beta
+public interface EntityReadOnlyInternal {
+
+ // from Entity
+
+ String getId();
+ long getCreationTime();
+ String getDisplayName();
+ @Nullable String getIconUrl();
+ EntityType getEntityType();
+ Application getApplication();
+ String getApplicationId();
+ Entity getParent();
+ Collection<Entity> getChildren();
+ Collection<Policy> getPolicies();
+ Collection<Enricher> getEnrichers();
+ Collection<Group> getGroups();
+ Collection<Location> getLocations();
+ <T> T getAttribute(AttributeSensor<T> sensor);
+ <T> T getConfig(ConfigKey<T> key);
+ <T> T getConfig(HasConfigKey<T> key);
+ Maybe<Object> getConfigRaw(ConfigKey<?> key, boolean includeInherited);
+ Maybe<Object> getConfigRaw(HasConfigKey<?> key, boolean
includeInherited);
+ @Deprecated Set<Object> getTags();
+ @Deprecated boolean containsTag(@Nonnull Object tag);
+
+
+ // from entity local
+
+ void setDisplayName(String displayName);
+ @Deprecated <T> T getConfig(ConfigKey<T> key, T defaultValue);
+ @Deprecated <T> T getConfig(HasConfigKey<T> key, T defaultValue);
+
+ // from EntityInternal:
+
+ EntityConfigMap getConfigMap();
+ Map<ConfigKey<?>,Object> getAllConfig();
+ // for rebind mainly
+ ConfigBag getAllConfigBag();
+ ConfigBag getLocalConfigBag();
+ Map<AttributeSensor, Object> getAllAttributes();
+ EntityManagementSupport getManagementSupport();
--- End diff --
should it instead be `EntityTransientCopyInternal` ?
this is really about what methods we internally permit to be invoked on the
RO copy. we need to access its management support, i'm pretty sure. we might
get away with not exposing `setDisplayName()` as that should be done pretty
close to construction time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
