Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/197#discussion_r18282187
--- Diff: core/src/main/java/brooklyn/entity/basic/AbstractEntity.java ---
@@ -676,7 +684,10 @@ public String getApplicationId() {
}
@Override
- public synchronized ManagementContext getManagementContext() {
+ public ManagementContext getManagementContext() {
+ // NB Sept 2014 - removed synch keyword above due to deadlock;
+ // it also synchs in ManagementSupport..getManagementContext();
+ // no apparent reason why it was here also. @aledsage can you
review?
--- End diff --
I appreciate @aledsage is a comprehensive reviewer but we shouldn't be
communicating with each other by comments in code!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
