Github user alasdairhodge commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/268#issuecomment-60221109
Changes look reasonable. Minor observations:
* Would much rather rely on explicit confirmation from the cloud API to
determine when it's safe to SSH to the remote machine, but realise this is a
bigger shift.
* Boolean flags should definitely be named in the positive sense to avoid
confusion; your suggested name is almost perfect, how about
`USE_JCLOUDS_SSH_INIT` (or `ENABLE_`)?
Still thinking about the implications of interrupting the `getOsDetails`
call...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
