Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/281#discussion_r19636319
--- Diff:
software/base/src/test/java/brooklyn/entity/software/mysql/DynamicToyMySqlEntityBuilder.java
---
@@ -149,10 +149,19 @@ protected void postStartCustom() {
// and set the PID
entity().setAttribute(Attributes.PID,
Integer.parseInt(DynamicTasks.queue(SshEffectorTasks.ssh("cat
"+dir(entity)+"/*/data/*.pid")).block().getStdout().trim()));
+
+ // TODO Without this, tests fail because nothing else sets
serviceUp!
+ // Really should set this with a Feed that checks pid
periodically.
+ // Should this instead be using SERVICE_NOT_UP_INDICATORS?
+ entity().setAttribute(Attributes.SERVICE_UP, true);
--- End diff --
Good question! It was experimental as a way to write entities, and to use
Chef.
I think now we're using the `ChefEntity` as the "proper" way, so arguably
none of this code should be needed.
@ahgittin is that true? If so, we should deprecate
`DynamicToyMysqlEntityBuilder`, with a comment pointing to `ChefEntity`.
I see that `ChefSoloDriverToyMySqlEntity` is already `@Deprecated` with a
comment saying to use `{Dynamic,Typed}ToyMySqlEntityChef`.
Is `DynamicToyMySqlEntityChef` still a recommended way, versus something
that instantiates a `ChefEntity` (the `TypedToyMySqlEntityChef` example extends
`ChefEntityImpl`)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
