Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/281#discussion_r19636596
--- Diff:
usage/launcher/src/test/java/brooklyn/launcher/BrooklynLauncherRebindToCloudObjectStoreTest.java
---
@@ -91,53 +91,56 @@ protected void checkPersistenceContainerNameIsDefault()
{
checkPersistenceContainerNameIs(BrooklynServerConfig.DEFAULT_PERSISTENCE_CONTAINER_NAME);
}
- @Override @Test(groups="Integration")
+ @Override @Test(groups="Live")
public void testRebindsToExistingApp() throws Exception {
super.testRebindsToExistingApp();
}
- @Override @Test(groups="Integration")
+ @Override @Test(groups="Live")
public void testRebindCanAddNewApps() throws Exception {
super.testRebindCanAddNewApps();
}
- @Override @Test(groups="Integration")
+ @Override @Test(groups="Live")
public void testAutoRebindsToExistingApp() throws Exception {
super.testAutoRebindsToExistingApp();
}
- @Override @Test(groups="Integration")
+ // TODO Marked as work-in-progress because "clean" does not backup and
then clean out the existing
+ // object store's bucket. Unclear what best behaviour there should be:
should we really delete
+ // the data?! We better be confident about our backup!
--- End diff --
The test fixture does create a new bucket for every test.
This particular test (`testCleanDoesNotRebindToExistingApp`) is explicitly
populating a new bucket, then starting an app with `--persist clean`. For
file-based persistence, that would backup the dir and then wipe it ready for a
clean brooklyn start. That is not done for persisting to object-store.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
