Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/542#discussion_r26207695
--- Diff:
software/base/src/main/java/brooklyn/entity/brooklynnode/BrooklynNodeImpl.java
---
@@ -153,17 +158,41 @@ protected void preStopConfirmCustom() {
@Override
protected void preStop() {
super.preStop();
+ if
(MachineLifecycleEffectorTasks.canStop(getStopProcessModeParam(), this)) {
+ shutdownGracefully();
+ }
+ }
+
+ private StopMode getStopProcessModeParam() {
+ ConfigBag parameters =
BrooklynTaskTags.getCurrentEffectorParameters();
+ if (parameters != null) {
+ return
parameters.get(StopSoftwareParameters.STOP_PROCESS_MODE);
+ } else {
+ return
StopSoftwareParameters.STOP_PROCESS_MODE.getDefaultValue();
+ }
+ }
+ @Override
+ protected void preRestart() {
+ super.preRestart();
+ shutdownGracefully();
--- End diff --
Deserves a comment to say why doing shutdown here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
