Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/542#discussion_r26207850
--- Diff:
software/base/src/test/java/brooklyn/entity/software/MachineLifecycleEffectorTasksTest.java
---
@@ -23,11 +23,17 @@
import org.testng.annotations.DataProvider;
import org.testng.annotations.Test;
+import brooklyn.entity.basic.BasicEntityImpl;
+import brooklyn.entity.basic.Lifecycle;
+import brooklyn.entity.basic.SoftwareProcess;
import
brooklyn.entity.basic.SoftwareProcess.StopSoftwareParameters.StopMode;
public class MachineLifecycleEffectorTasksTest {
public static boolean canStop(StopMode stopMode, boolean
isEntityStopped) {
- return MachineLifecycleEffectorTasks.canStop(stopMode,
isEntityStopped);
+ BasicEntityImpl entity = new BasicEntityImpl();
--- End diff --
ok for now, but at some point calling the entity constructor directly may
give us very surprising subsequent behaviour (e.g. because not managed, and no
management context injected).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
