Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/542#discussion_r26207980
--- Diff:
usage/jsgui/src/test/java/brooklyn/rest/jsgui/BrooklynJavascriptGuiLauncherTest.java
---
@@ -60,8 +61,15 @@ public void testJavascriptWithRest() throws Exception {
checkUrlContains("/v1/catalog/entities", "Tomcat");
}
- protected void checkUrlContains(String path, String text) {
- HttpTestUtils.assertContentContainsText(rootUrl()+path, text);
+ protected void checkUrlContains(final String path, final String text) {
+ //Server may return 403 until it loads completely, wait a bit
+ //until it stabilizes.
+ Asserts.succeedsEventually(new Runnable() {
--- End diff --
Can use `HttpTestUtils.assertContentEventuallyContainsText(rootUrl()+path,
text)`.
I'd really like consistency for our assertXxxEventuallyYyy versus
assertXxxYyyEventually. Personally, I much prefer the latter because we often
also have an assertXxxYyy method - having the Eventually as a suffix keeps the
methods together more. But that's an aside...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
