Github user andreaturli commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/707#issuecomment-114045925
@ygy thanks for that! great start!
Do you think it is possible to refactor a bit your implementation? It would
be nice to rename `IptablesCommands` a more generic `FirewallCommands`
interface, which is able to use the correct implementation (`iptables` vs
`firewalld` and possibly `windows firewall`) based on the OsFamily to make it
more portable?
If so, we should probably deprecate `IptablesCommands` instead of removing
it immediately.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
