Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/707#discussion_r32920648
--- Diff:
locations/jclouds/src/main/java/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -364,7 +364,15 @@ public boolean isWindows(NodeMetadata node, ConfigBag
config) {
? (OsFamily.WINDOWS == os.getFamily())
: (OsFamily.WINDOWS == confFamily);
}
-
+
+ public boolean isNodeFirewalldEnabled(NodeMetadata node) {
+ String OS = node.getOperatingSystem().getFamily().toString();
+ String version = node.getOperatingSystem().getVersion();
+ return node.getOperatingSystem().getVersion().startsWith("7") &&
+ (node.getOperatingSystem().getFamily().equals(OsFamily.RHEL)
||
+
node.getOperatingSystem().getFamily().equals(OsFamily.CENTOS));
--- End diff --
The check is not future proof. Instead of checking fixed OS versions is it
possible to check for the existence of firewall-cmd instead? This will allow
the blueprint to work on future versions of the OS without any changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
