Github user bostko commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/866#discussion_r37966653
  
    --- Diff: 
core/src/test/java/org/apache/brooklyn/location/byon/ByonLocationResolverTest.java
 ---
    @@ -345,7 +345,7 @@ public void testWindowsMachines(String osFamily) throws 
Exception {
             String spec = "byon";
             Map<String, ?> flags = ImmutableMap.of(
                     "hosts", ImmutableList.of("1.1.1.1", "2.2.2.2"),
    -                "osfamily", osFamily
    +                "osFamily", "windows"
    --- End diff --
    
    I am doing exactly this.
    I've changed it from osfamily to osFamily.
    Notice that this was only in ByonLocationResolver. Can you check my PR 
comment on top. What do you think for moving this parameter in AbstractLocation


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to