zyearn commented on a change in pull request #694: Health check by rpc call
URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268103165
##########
File path: src/brpc/socket.cpp
##########
@@ -780,6 +793,9 @@ void Socket::Revive() {
} else {
LOG(INFO) << "Revived " << *this;
}
+ if (FLAGS_health_check_using_rpc) {
Review comment:
对的，不过这个问题一直存在。放while循环之前也不行，没有compare_exchange_weak成功还得恢复回来，这里有挺多竞争问题的
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
