zyearn commented on a change in pull request #694: Health check by rpc call
URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268381737
##########
File path: src/brpc/socket.cpp
##########
@@ -780,6 +793,9 @@ void Socket::Revive() {
} else {
LOG(INFO) << "Revived " << *this;
}
+ if (FLAGS_health_check_using_rpc) {
Review comment:
revive这个函数似乎是不存在竞争的，compare_exchange_weak是必成功的，那把这些操作放到compare_exchange_weak就可以了
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
