zyearn commented on a change in pull request #878: Use prebuilt MesaLink package in travis CI URL: https://github.com/apache/incubator-brpc/pull/878#discussion_r311363556
########## File path: .travis.yml ########## @@ -11,8 +11,10 @@ env: - PURPOSE=unittest - PURPOSE=compile-with-cmake - PURPOSE=compile-with-bazel -#- PURPOSE=compile USE_MESALINK=yes -#- PURPOSE=unittest USE_MESALINK=yes +- PURPOSE=compile USE_MESALINK=yes +- PURPOSE=unittest USE_MESALINK=yes +- PURPOSE=compile-with-cmake USE_MESALINK=yes +- PURPOSE=compile-with-bazel USE_MESALINK=yes Review comment: There are many compilation options, such as with-glog, with-thrift. Just compiling with mesalink in travis seems not a general way to test all options. I think it may be a better way to add one specific PURPOSE called compile-with-all-options and we can turn on all the options here, not just mesalink. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
