zyearn commented on a change in pull request #878: Use prebuilt MesaLink
package in travis CI
URL: https://github.com/apache/incubator-brpc/pull/878#discussion_r311845007
##########
File path: CMakeLists.txt
##########
@@ -167,6 +182,7 @@ set(DYNAMIC_LIB
${THRIFTNB_LIB}
${OPENSSL_LIBRARIES}
${OPENSSL_CRYPTO_LIBRARY}
+ ${MESALINK_LIB}
Review comment:
What if WITH_MESALINK is defined but openssl is in system and still be
found? In the current cmake, brpc may still use openssl?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
