zyearn commented on a change in pull request #878: Use prebuilt MesaLink
package in travis CI
URL: https://github.com/apache/incubator-brpc/pull/878#discussion_r312329955
##########
File path: CMakeLists.txt
##########
@@ -167,6 +182,7 @@ set(DYNAMIC_LIB
${THRIFTNB_LIB}
${OPENSSL_LIBRARIES}
${OPENSSL_CRYPTO_LIBRARY}
+ ${MESALINK_LIB}
Review comment:
Thanks for your detailed explanation. In any case either
${OPENSSL_LIBRARIES} or ${MESALINK_LIB} is used, it's enough to link just one
of them. So it may be more clear if we remove ${OPENSSL_LIBRARIES} when
mesalink is used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
