chenBright commented on code in PR #2493:
URL: https://github.com/apache/brpc/pull/2493#discussion_r1443656015
##########
src/brpc/server.cpp:
##########
@@ -564,6 +565,10 @@ int Server::AddBuiltinServices() {
LOG(ERROR) << "Fail to add GetJsService";
return -1;
}
+ if (AddBuiltinService(new (std::nothrow) GrpcHealthCheckService)) {
Review Comment:
如果ServerOptions::enabled_protocols没有h2，是不是没有必要打开这个内置服务呢？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
