chenBright commented on code in PR #2493:
URL: https://github.com/apache/brpc/pull/2493#discussion_r1444138945
##########
src/brpc/server.cpp:
##########
@@ -564,6 +565,10 @@ int Server::AddBuiltinServices() {
LOG(ERROR) << "Fail to add GetJsService";
return -1;
}
+ if (AddBuiltinService(new (std::nothrow) GrpcHealthCheckService)) {
Review Comment:
这是跟协议强相关，加个协议的检查，合适一点吧
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
