jiangyt-git commented on code in PR #2493:
URL: https://github.com/apache/brpc/pull/2493#discussion_r1446055196
##########
src/brpc/server.cpp:
##########
@@ -565,13 +565,22 @@ int Server::AddBuiltinServices() {
LOG(ERROR) << "Fail to add GetJsService";
return -1;
}
- if (AddBuiltinService(new (std::nothrow) GrpcHealthCheckService)) {
+ if (ProtocolEnabled("h2") &&
+ AddBuiltinService(new (std::nothrow) GrpcHealthCheckService)) {
LOG(ERROR) << "Fail to add GrpcHealthCheckService";
return -1;
}
return 0;
}
+bool Server::ProtocolEnabled(const char * name) {
+ if (!_options.enabled_protocols.empty() &&
+ _options.enabled_protocols.find(name) == std::string::npos) {
Review Comment:
这个需要这么的严格吗？这个要检查，绝对检查的话只检查h2:grpc也可以，但如果用户server 设置了 h2、h2:proto 、h2:json
等应该也可以给调通。以及未来有可能支持的h2:grpc streaming。 当然如果你觉得要需要的话，我也可以改成split之后的严格检查。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
