yanglimingcn commented on code in PR #2923:
URL: https://github.com/apache/brpc/pull/2923#discussion_r2009353993


##########
src/brpc/server.h:
##########
@@ -601,6 +601,16 @@ class Server {
     int MaxConcurrencyOf(google::protobuf::Service* service,
                          const butil::StringPiece& method_name) const;
 
+    // Reset max_concurrency associated with a method.
+    int ResetMaxConcurrencyOf(const butil::StringPiece& full_method_name,

Review Comment:
   
下面这个FindMethodPropertyByFullName函数估计是能满足需求的,但是需要判断一下返回值是否为NULL,然后再调用后续的MaxConcurrencyOf/ResetMaxConcurrencyOf等方法,这么修改后这些方法的Of应该就要去掉了。
   感觉这样用户使用起来要分两步走,1、获取method,2、判断method存在后再做后续的动作。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org

Reply via email to