yanglimingcn commented on code in PR #2923:
URL: https://github.com/apache/brpc/pull/2923#discussion_r2009533376


##########
src/brpc/server.h:
##########
@@ -601,6 +601,16 @@ class Server {
     int MaxConcurrencyOf(google::protobuf::Service* service,
                          const butil::StringPiece& method_name) const;
 
+    // Reset max_concurrency associated with a method.
+    int ResetMaxConcurrencyOf(const butil::StringPiece& full_method_name,

Review Comment:
   
好像还有些问题,这些类型的协议不在method_map里面,它只返回_max_concurrency。SetMaxConcurrency和ResetMaxConcurrency操作的是MethodProperty里面的不同字段。
           if (full_method_name == butil::class_name_str<NsheadService>()) {
               if (NULL == options().nshead_service) {
                   break;
               }
               return options().nshead_service->_max_concurrency;
           }
   #ifdef ENABLE_THRIFT_FRAMED_PROTOCOL
           if (full_method_name == butil::class_name_str<ThriftService>()) {
               if (NULL == options().thrift_service) {
                   break;
               }
               return options().thrift_service->_max_concurrency;
           }
   #endif
           if (full_method_name == butil::class_name_str<BaiduMasterService>()) 
{
               if (NULL == options().baidu_master_service) {
                   break;
               }
               return options().baidu_master_service->_max_concurrency;
           }



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org

Reply via email to