wwbmmm commented on code in PR #2923:
URL: https://github.com/apache/brpc/pull/2923#discussion_r2011259037
##########
src/brpc/details/method_status.h:
##########
@@ -58,6 +58,11 @@ class MethodStatus : public Describable {
// Current max_concurrency of the method.
int MaxConcurrency() const { return _cl ? _cl->MaxConcurrency() : 0; }
+ // Reset max_concurrency of the method.
+ int ResetMaxConcurrency(const AdaptiveMaxConcurrency& concurrency) {
Review Comment:
这个是不是没用了
##########
src/brpc/adaptive_max_concurrency.cpp:
##########
@@ -82,6 +83,9 @@ void AdaptiveMaxConcurrency::operator=(int max_concurrency) {
_value = butil::string_printf("%d", max_concurrency);
_max_concurrency = max_concurrency;
}
+ if (_cl) {
Review Comment:
另外两个operator=重载是不是也得加一下
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
