wwbmmm commented on code in PR #2923:
URL: https://github.com/apache/brpc/pull/2923#discussion_r2007244682
##########
src/brpc/policy/auto_concurrency_limiter.cpp:
##########
@@ -134,6 +134,8 @@ int AutoConcurrencyLimiter::MaxConcurrency() {
return _max_concurrency;
}
+int AutoConcurrencyLimiter::ResetMaxConcurrency(const AdaptiveMaxConcurrency&)
{ return -1; }
Review Comment:
return加个换行吧
##########
src/brpc/server.h:
##########
@@ -601,6 +601,16 @@ class Server {
int MaxConcurrencyOf(google::protobuf::Service* service,
const butil::StringPiece& method_name) const;
+ // Reset max_concurrency associated with a method.
+ int ResetMaxConcurrencyOf(const butil::StringPiece& full_method_name,
Review Comment:
感觉有点组合爆炸了，
是不是可以把获取method和操作method分成两步
比如server.GetMethod("EchoService.echo").ResetMaxConcurrency(conncurrency)
##########
src/brpc/policy/timeout_concurrency_limiter.cpp:
##########
@@ -117,6 +117,8 @@ int TimeoutConcurrencyLimiter::MaxConcurrency() {
return FLAGS_timeout_cl_max_concurrency;
}
+int TimeoutConcurrencyLimiter::ResetMaxConcurrency(const
AdaptiveMaxConcurrency &) { return -1; }
Review Comment:
同上
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
