Dayuxiaoshui commented on code in PR #3125:
URL: https://github.com/apache/brpc/pull/3125#discussion_r2463391248
##########
CMakeLists.txt:
##########
@@ -170,6 +170,9 @@ if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
elseif((CMAKE_SYSTEM_PROCESSOR MATCHES "aarch64"))
# segmentation fault in libcontext
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-gcse")
+ elseif((CMAKE_SYSTEM_PROCESSOR MATCHES "riscv64"))
Review Comment:
There is currently no need to add -fno-gcse for RISC-V in Bazel.I think if
the same issue is reproduced on riscv64, then add it to both CMake and Bazel at
the same time (set --copt=-fno-gcse per architecture in .bazelrc).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
