Dayuxiaoshui commented on code in PR #3125:
URL: https://github.com/apache/brpc/pull/3125#discussion_r2468789631
##########
CMakeLists.txt:
##########
@@ -170,6 +170,9 @@ if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
elseif((CMAKE_SYSTEM_PROCESSOR MATCHES "aarch64"))
# segmentation fault in libcontext
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-gcse")
+ elseif((CMAKE_SYSTEM_PROCESSOR MATCHES "riscv64"))
Review Comment:
If RVV (vector extension) is needed in the future, it should be chosen by
the user or a dedicated toolchain with -march=rv64gcv, and should not be
enabled by default in general-purpose libraries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
