chenBright commented on code in PR #3125:
URL: https://github.com/apache/brpc/pull/3125#discussion_r2466110466
##########
CMakeLists.txt:
##########
@@ -170,6 +170,9 @@ if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
elseif((CMAKE_SYSTEM_PROCESSOR MATCHES "aarch64"))
# segmentation fault in libcontext
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-gcse")
+ elseif((CMAKE_SYSTEM_PROCESSOR MATCHES "riscv64"))
Review Comment:
https://github.com/apache/brpc/blob/8ef24ba08ef8aa78f9125713aef122a9b6ccf260/BUILD.bazel#L23-L36
So on riscv64 platform, does -march=rv64gc need to be added to COPTS?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
