chenBright commented on code in PR #3145:
URL: https://github.com/apache/brpc/pull/3145#discussion_r2508668882
##########
src/brpc/rdma/rdma_endpoint.cpp:
##########
@@ -513,7 +520,10 @@ void* RdmaEndpoint::ProcessHandshakeAtClient(void* arg) {
std::min(ep->_sq_size, remote_msg.rq_size) - RESERVED_WR_NUM;
ep->_remote_window_capacity =
std::min(ep->_rq_size, remote_msg.sq_size) - RESERVED_WR_NUM,
- ep->_window_size.store(ep->_local_window_capacity,
butil::memory_order_relaxed);
+ ep->_remote_rq_window_size.store(
Review Comment:
ibv_post_send is limited by the local sq and the remote rq, but
_remote_window_capacity is the minimum value of the local rq and the remote sq,
so the maximum value of _remote_rq_window_size should not be equal to
_remote_window_capacity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
