yanglimingcn commented on code in PR #3145:
URL: https://github.com/apache/brpc/pull/3145#discussion_r2512619046
##########
src/brpc/rdma/rdma_endpoint.cpp:
##########
@@ -894,11 +913,14 @@ ssize_t RdmaEndpoint::CutFromIOBufList(butil::IOBuf**
from, size_t ndata) {
_sq_current = 0;
}
- // Update _window_size. Note that _window_size will never be negative.
+ // Update `_remote_rq_window_size' and `_sq_window_size'. Note that
+ // `_remote_rq_window_size' and `_sq_window_size' will never be
negative.
// Because there is at most one thread can enter this function for each
- // Socket, and the other thread of HandleCompletion can only add this
- // counter.
- _window_size.fetch_sub(1, butil::memory_order_relaxed);
+ // Socket, and the other thread of HandleCompletion can only add these
+ // counters.
+ remote_rq_window_size =
Review Comment:
Assigning values to remote_rq_window_size and sq_window_size here is
meaningless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
