yanglimingcn commented on code in PR #3145:
URL: https://github.com/apache/brpc/pull/3145#discussion_r2512622699
##########
src/brpc/rdma/rdma_endpoint.cpp:
##########
@@ -972,9 +1001,9 @@ ssize_t RdmaEndpoint::HandleCompletion(ibv_wc& wc) {
// Update window
uint32_t wnd_thresh = _local_window_capacity / 8;
- if (_window_size.fetch_add(acks, butil::memory_order_relaxed) >=
wnd_thresh
+ if (_remote_rq_window_size.fetch_add(acks,
butil::memory_order_relaxed) >= wnd_thresh
|| acks >= wnd_thresh) {
- // Do not wake up writing thread right after _window_size > 0.
+ // Do not wake up writing thread right after
_remote_rq_window_size > 0.
Review Comment:
comment update "> wnd_thresh"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
