randomkang commented on code in PR #3144:
URL: https://github.com/apache/brpc/pull/3144#discussion_r2514226807


##########
src/brpc/rdma/rdma_endpoint.cpp:
##########
@@ -922,31 +933,57 @@ int RdmaEndpoint::SendImm(uint32_t imm) {
     wr.imm_data = butil::HostToNet32(imm);
     wr.send_flags |= IBV_SEND_SOLICITED;
     wr.send_flags |= IBV_SEND_SIGNALED;
+    wr.wr_id = FIXED_ACK_WR_ID;
 
     ibv_send_wr* bad = NULL;
     int err = ibv_post_send(_resource->qp, &wr, &bad);
     if (err != 0) {
         // We use other way to guarantee the Send Queue is not full.
         // So we just consider this error as an unrecoverable error.
-        LOG(WARNING) << "Fail to ibv_post_send: " << berror(err);
+        LOG(WARNING) << "Fail to ibv_post_send: " << berror(err)
+                     << ", window_size:" <<  _window_size
+                     << ", remote_recv_window: " << _remote_recv_window;
         return -1;
     }
     return 0;
 }
 
 ssize_t RdmaEndpoint::HandleCompletion(ibv_wc& wc) {
     bool zerocopy = FLAGS_rdma_recv_zerocopy;
+    //LOG(INFO) << "Handle Completion: " << wc.opcode;

Review Comment:
   we note that #3145 is a solution of two windows, we will revert this part 
from #3144 .



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to