randomkang commented on code in PR #3144:
URL: https://github.com/apache/brpc/pull/3144#discussion_r2527850195
##########
src/brpc/policy/baidu_rpc_protocol.cpp:
##########
@@ -101,44 +106,116 @@ static void SerializeRpcHeaderAndMeta(
ParseResult ParseRpcMessage(butil::IOBuf* source, Socket* socket,
bool /*read_eof*/, const void*) {
+
char header_buf[12];
- const size_t n = source->copy_to(header_buf, sizeof(header_buf));
+ size_t n = 0;
Review Comment:
Maybe put GPU functionality into a separate file or define a new protocol is
two heavy, we reorg the code to decrease the macro definitions. Is it ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
