zchuang185 commented on code in PR #3144:
URL: https://github.com/apache/brpc/pull/3144#discussion_r2546166243
##########
src/brpc/policy/baidu_rpc_protocol.cpp:
##########
@@ -101,44 +106,116 @@ static void SerializeRpcHeaderAndMeta(
ParseResult ParseRpcMessage(butil::IOBuf* source, Socket* socket,
bool /*read_eof*/, const void*) {
+
char header_buf[12];
- const size_t n = source->copy_to(header_buf, sizeof(header_buf));
+ size_t n = 0;
Review Comment:
I think it's better to separate new protocol file for GDR featureļ¼ Besides,
I have a idea we can also define a new protocol meta that includes both request
meta and response meta carrying the GDR attribute value., the corresponding
meta should also contain the GPU address information that both sides need to
register with IB. Doing the GDR operations inside processRequest and
ProcessRpcResponse method step will probably be more reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
