I got the 911 PR from Jinfeng, reviewed and tested, and it's in. Thanks, Jinfeng!
Jesus, We're good to go for RC 1. Draft release notes: https://github.com/julianhyde/calcite/tree/branch-1.5 A thread on infrastructure-dev [1] suggests that you use "-DlocalCheckout=false -DpushChanges=false" to prevent maven-release-plugin from pushing changes to apache git that cannot be overwritten. Seems like good advice to me. Julian [1] https://mail-archives.apache.org/mod_mbox/www-infrastructure-dev/201511.mbox/%3CCAKa9qDmG8=dr2rvqtc+o9dgeetg098qfow4efk4fcflm8gm...@mail.gmail.com%3E On Thu, Nov 5, 2015 at 12:30 AM, Jesus Camacho Rodriguez <[email protected]> wrote: > We are done with 949 (not an issue finally). I'll be waiting for Jinfeng > patch, then start the vote. > > Thanks, > Jesús > > > > On 11/5/15, 6:28 AM, "Jinfeng Ni" <[email protected]> wrote: > >>Thanks a lot for the review comments, Julian! >> >>I'll address the comments and get a revised patch tomorrow. Hopefully, >>we can get it merged to this release. :-) >> >>Regards, >> >>Jinfeng >> >> >>On Wed, Nov 4, 2015 at 8:57 PM, Julian Hyde <[email protected]> wrote: >>> I just reviewed 911. The tests all pass, and I now think that the chances >>> that it will destabilize anything are low. If Jinfeng can get the review >>> actions done tomorrow I think it could go into the release. >>> >>> Julian >>> >>> >>>> On Nov 4, 2015, at 4:17 PM, Julian Hyde <[email protected]> wrote: >>>> >>>> Draft release notes here: >>>> https://github.com/julianhyde/calcite/blob/branch-1.5/site/_docs/history.md >>>> >>>> <https://github.com/julianhyde/calcite/blob/branch-1.5/site/_docs/history.md> >>>> >>>> Apache have just changed their git policy: previously you could alter >>>> history (delete branch or force push) on any branch other than master. Now >>>> you cannot alter history on any branch. Shame, because you used to be able >>>> to make any mess you liked on a release staging branch and clean it up >>>> just before the release. >>>> >>>> Julian >>>> >>>> >>>>> On Nov 4, 2015, at 1:28 PM, Julian Hyde <[email protected] >>>>> <mailto:[email protected]>> wrote: >>>>> >>>>> I just committed 845, 951, 952. Just 949 left. >>>>> >>>>> I’ll also write some draft release notes. >>>>> >>>>> Julian >>>>> >>>>> >>>>>> On Nov 4, 2015, at 10:44 AM, Julian Hyde <[email protected] >>>>>> <mailto:[email protected]>> wrote: >>>>>> >>>>>> I am testing 845 now and will shortly commit. And I think 948, 949, 951, >>>>>> 952 should go in. (They need to be reviewed first.) >>>>>> >>>>>> Everything else should wait. Including 816 and 911. >>>>>> >>>>>> Anyone disagree? >>>>>> >>>>>> Julian >>>>>> >>>>>> >>>>>>> On Nov 4, 2015, at 10:07 AM, Maryann Xue <[email protected] >>>>>>> <mailto:[email protected]>> wrote: >>>>>>> >>>>>>> Just submitted a patch for CALCITE-952, which is related to CALCITE-890. >>>>>>> Hope it can go into the release. >>>>>>> >>>>>>> On Wed, Nov 4, 2015 at 12:46 PM, Josh Elser <[email protected] >>>>>>> <mailto:[email protected]>> wrote: >>>>>>> >>>>>>>> I just threw up one more/last Avatica fix that I apparently >>>>>>>> goofed/omitted >>>>>>>> the first time around. Rather trivial changes, but I can understand the >>>>>>>> need to say no and stop bringing in new stuff :) >>>>>>>> >>>>>>>> https://issues.apache.org/jira/browse/CALCITE-951 >>>>>>>> <https://issues.apache.org/jira/browse/CALCITE-951> >>>>>>>> https://github.com/apache/calcite/pull/165 >>>>>>>> >>>>>>>> >>>>>>>> Jesus Camacho Rodriguez wrote: >>>>>>>> >>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-948 that fixed the >>>>>>>>> problem >>>>>>>>> with the RelFieldTrimmer went in yesterday. >>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-890 and >>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-936 have gone in too. >>>>>>>>> >>>>>>>>> I think we can probably check in >>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-845 and >>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-949, and start with the >>>>>>>>> vote for the release. >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Jesús >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On 11/3/15, 4:34 PM, "Jesus Camacho Rodriguez"< >>>>>>>>> [email protected]> wrote: >>>>>>>>> >>>>>>>>> Thanks Julian. >>>>>>>>>> >>>>>>>>>> I will try to start the vote tomorrow; I'm still trying to figure >>>>>>>>>> out if >>>>>>>>>> the problem with in RelFieldTrimmer is in Calcite or Hive specific >>>>>>>>>> (because >>>>>>>>>> of the special treatment that we do of grouping ID). >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Jesús >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On 11/2/15, 8:15 PM, "Julian Hyde"<[email protected]> wrote: >>>>>>>>>> >>>>>>>>>> Welcome back, Jesus. >>>>>>>>>>> >>>>>>>>>>> Where are we on the release? From my end, I am still not ready to >>>>>>>>>>> check in the branch for >>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-816 and I think it >>>>>>>>>>> will >>>>>>>>>>> cause some destabilization when it goes in. I checked in a lot of >>>>>>>>>>> patches in the last week or so and I think the master branch is in >>>>>>>>>>> good shape. >>>>>>>>>>> >>>>>>>>>>> I think it is in the best interests of the project to make a release >>>>>>>>>>> with what we have now; we can make a short release when 816 is ready >>>>>>>>>>> and stable. >>>>>>>>>>> >>>>>>>>>>> There are outstanding patches from Maryann ( >>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-845 and >>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-890 ) and Navis ( >>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-936 ) which are low >>>>>>>>>>> risk >>>>>>>>>>> and could go in before a vote. >>>>>>>>>>> >>>>>>>>>>> Julian >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On Mon, Nov 2, 2015 at 7:09 AM, Jesus Camacho Rodriguez >>>>>>>>>>> <[email protected]> wrote: >>>>>>>>>>> >>>>>>>>>>>> Catching up with the release, as I was on vacation last week. >>>>>>>>>>>> >>>>>>>>>>>> I am tracking an issue in RelFieldTrimmer that I have detected in >>>>>>>>>>>> Hive >>>>>>>>>>>> QA run (seems related to Aggregate operators and grouping sets >>>>>>>>>>>> treatment). >>>>>>>>>>>> I will post another update asap. >>>>>>>>>>>> >>>>>>>>>>>> Thanks, >>>>>>>>>>>> Jesús >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> On 10/28/15, 3:22 AM, "Josh Elser"<[email protected]> wrote: >>>>>>>>>>>> >>>>>>>>>>>> https://github.com/apache/calcite/pull/140 should be up to date for >>>>>>>>>>>>> CALCITE-903 >>>>>>>>>>>>> >>>>>>>>>>>>> Josh Elser wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks, Julian. >>>>>>>>>>>>>> >>>>>>>>>>>>>> I'm hoping on a patch for tmrw. Still working through fallout >>>>>>>>>>>>>> from >>>>>>>>>>>>>> the >>>>>>>>>>>>>> patch being out of date. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Julian Hyde wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> 938 and PR 160 are now both in. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Next up… 903, Josh? >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Also hoping for 911 from Jinfeng and 936 from Navis. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Julian >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Oct 26, 2015, at 12:07 PM, Maryann Xue<[email protected]> >>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Just created and submitted patch for CALCITE-938. Would be >>>>>>>>>>>>>>>> great >>>>>>>>>>>>>>>> if that >>>>>>>>>>>>>>>> one could be included in 1.5. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>> Maryann >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On Mon, Oct 26, 2015 at 2:42 PM, Julian Hyde<[email protected]> >>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Thanks Josh. Reviewing PR 160 now. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> On Sun, Oct 25, 2015 at 9:09 PM, Josh >>>>>>>>>>>>>>>>> Elser<[email protected]> >>>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Julian Hyde wrote: >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Great. I've listed your assignments (and everyone else's) >>>>>>>>>>>>>>>>>>> below. >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Assignments: >>>>>>>>>>>>>>>>>>> * Josh: 921, 913, 871, 903 >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> FYI 921, 913 and 871 are contained in >>>>>>>>>>>>>>>>>> https://github.com/apache/incubator-calcite/pull/160 >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> CALCITE-903 is going to take a day or so after CALCITE-705. I >>>>>>>>>>>>>>>>>> wasn't >>>>>>>>>>>>>>>>>> watching close enough and the original patch is rather out of >>>>>>>>>>>>>>>>>> date >>>>>>>>>>>>>>>>>> now. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>> >>>>> >>>> >>> >>
