Sorry, You already separated logical steps very cleanly! The PR would be useful for live comments as well
Will take a deep look soon Enrico Il sab 7 lug 2018, 23:02 Enrico Olivelli <[email protected]> ha scritto: > It would be useful to create a PR so that github creates the live diff and > we can add comments. > I am very interested in this change. > Thank you Julian for this great work > > Enrico > > > > Il sab 7 lug 2018, 22:29 Julian Hyde <[email protected]> ha scritto: > >> I have two major changes ready to check in. Can someone please review >> them? >> >> * https://issues.apache.org/jira/browse/CALCITE-2280 Babel SQL parser >> * https://issues.apache.org/jira/browse/CALCITE-2259 Java 8 syntax >> >> Both are staged in the same branch - >> https://github.com/julianhyde/calcite/commits/2280-babel - but it >> could be different people reviewing each. >> >> I am especially interested in high-level comments about design and >> development practices. >> >> Julian >> > -- > > > -- Enrico Olivelli > -- -- Enrico Olivelli
