On Sun, Jul 8, 2018 at 5:42 AM, Enrico Olivelli <[email protected]> wrote: > I am sorry I have not much time to try out the branch and do some of the > implementations on Babel before 1.17 release (which I am assuming it to be > immediate after merging this feature branch)
No worries - this is just a start. > Most of my problems are about letting some reserved words to be used as > column/schema/table identifiers (like havung a table with name 'user' or a > schema with name 'default') and it seems pretty simple to implement, if I > am userstanding correctly how Babel works. I agree, reducing the number of reserved words would be useful. Can you log a JIRA case for this, please. > I would like also to add support for writing timestamps values as raw > strings. Also agree. Can you log a JIRA case, with an example query that you think should succeed. > There are a lot of changes (thinking about java8 syntax) and bugs are > likely to be added. I did a scan thru the change and apparently it looks > okay but there are tons of small changes. There are a lot of changes, but I was pretty careful (e.g. I used intellij refactorings whenever possible). I ran the test suite often as I was making changes, and I did not see many accidental breakages occurring. > I really like that Calcite is moving away from Guava Yes, we're ditching things in Guava that are now done by the JDK. I remain a big fan of Guava's immutable collections. Thanks for the review. Julian
