I just merged both commits (and quite a few commits by other contributors) to master.
> On Jul 8, 2018, at 3:44 PM, Julian Hyde <[email protected]> wrote: > > On Sat, Jul 7, 2018 at 3:56 PM, Michael Mior <[email protected]> wrote: > >> I've done a scan of the code and it looks great to me. Also compiled >> and ran tests on my machine just in case. I love commits that delete >> more code than they add (over 2,600 deleted lines!) > > I had no idea I'd net-deleted code. A nice side effect! > >> Thanks for this Julian! I know making these kinds >> of sweeping changes can be pretty dreary. > > You're welcome. It's a good investment, making sure that the code has > a consistent and modern style that others can emulate. > >> I noticed you had a couple suggestions in your commit message for >> future changes. Should there be JIRA issues logged for these? (If >> there haven't been already). > > I don't feel strongly one way or the other. > >> Also, with all the new deprecations that >> have been added (which I agree with), I wonder if it's time to start >> thinking about planning a 2.0 release? > > Good point. I do think it is worth thinking about 2.0. We're never > going to have a "big bang" feature that justifies a major version -- > nor should we, I think our community likes that we move incrementally > -- but it's time to clean house, and a major version gives us that > opportunity. > >> In any case, since the changes are so pervasive, it would be good to >> get this merged as soon as possible to avoid conflicts with future >> PRs. > > I agree. There was considerable bit-rot just over the last two months > (because of conflicts with other changes that have come in). > > Thanks for the review. > > Julian
