zabetak commented on a change in pull request #898: [CALCITE-2464] Allow to set
nullability for columns of structured types (Ruben Quesada Lopez)
URL: https://github.com/apache/calcite/pull/898#discussion_r258528979
##########
File path:
core/src/test/java/org/apache/calcite/sql/type/SqlTypeFactoryTest.java
##########
@@ -112,6 +121,26 @@ private void checkPrecision(int p0, int p1, int
expectedMax,
assertThat(SqlTypeUtil.comparePrecision(p1, p1), is(0));
}
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-2464";>[CALCITE-2464]
+ * Allow to set nullability for columns of structured types</a>. */
+ @Test
+ public void createTypeWithNullability() {
Review comment:
Shouldn't the name of the test reflect the fact that it only tests stuctured
types?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
