zabetak commented on a change in pull request #898: [CALCITE-2464] Allow to set
nullability for columns of structured types (Ruben Quesada Lopez)
URL: https://github.com/apache/calcite/pull/898#discussion_r259330299
##########
File path: server/src/main/java/org/apache/calcite/sql/ddl/SqlCreateTable.java
##########
@@ -176,6 +176,9 @@ public void execute(CalcitePrepare.Context context) {
type = typeEntry.getType().apply(typeFactory);
}
}
+ if (type != null && !type.isNullable() && d.strategy ==
ColumnStrategy.NULLABLE) {
Review comment:
I don't see a better option at the moment so I agree with you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
