zabetak commented on a change in pull request #898: [CALCITE-2464] Allow to set
nullability for columns of structured types (Ruben Quesada Lopez)
URL: https://github.com/apache/calcite/pull/898#discussion_r259328399
##########
File path: core/src/main/java/org/apache/calcite/jdbc/JavaTypeFactoryImpl.java
##########
@@ -243,11 +243,24 @@ public RelDataType toSql(RelDataType type) {
/** Converts a type in Java format to a SQL-oriented type. */
public static RelDataType toSql(final RelDataTypeFactory typeFactory,
RelDataType type) {
+ return toSql(typeFactory, type, true);
+ }
+
+ private static RelDataType toSql(final RelDataTypeFactory typeFactory,
+ RelDataType type, boolean isRootType) {
Review comment:
I would rename `isRootType` to `mustConsiderNullability` or
`mustSetNullability` or something similar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
